Messages in this thread | | | Date | Fri, 21 Apr 2006 17:07:45 +0200 (MEST) | From | Jan Engelhardt <> | Subject | Re: kfree(NULL) |
| |
>> Maybe kfree should really be a wrapper around __kfree which does the real >> work. Then kfree could be a inlined function or a #define that does the NULL >> pointer check. > >NULL pointer check in kfree saves lot of small code fragments in callers. >It is one of many reasons why kfree does it. >Making kfree inline wrapper eliminates this save.
How about
slab.h: #ifndef CONFIG_OPTIMIZING_FOR_SIZE static inline void kfree(const void *p) { if(p != NULL) __kfree(p); } #else extern void kfree(const void *); #endif
slab.c: #ifdef CONFIG_OPTIMIZING_FOR_SIZE void kfree(const void *p) { if(p != NUILL) _kfree(p); } #endif
That way, you get your time saving with -O2 and your space saving with -Os.
Jan Engelhardt -- - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |