Messages in this thread | | | From | Arnd Bergmann <> | Subject | Re: [PATCH] fix spu_callbacks BUILD_BUG_ON | Date | Fri, 21 Apr 2006 15:52:38 +0200 |
| |
On Friday 21 April 2006 15:14, Jan Engelhardt wrote: > + [__NR_syscalls] = NULL, > > > }; > >
> >- if (s->nr_ret >= __NR_syscalls) { > >+ if (s->nr_ret >= ARRAY_SIZE(spu_syscall_table)) { > > + if(syscall == NULL) { > > > > That way, syscalls could be added in the master table while spu does not > break. Comments?
Hmm, my idea was not having to check for NULL pointers when we know that they are valid function calls. But you are right that your approach is more robust. It also means that we might just leave out all the assignments to sys_ni_syscall in order to make the source a little shorter.
Arnd <>< - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |