Messages in this thread | | | Date | Fri, 21 Apr 2006 12:55:43 +0900 (JST) | Subject | Re: [PATCH linux-2.6.17-rc1] net: fix neigh_delete to handle mult. tables | From | YOSHIFUJI Hideaki / 吉藤英明 <> |
| |
In article <4448520C.5080508@donlaw.com> (at Thu, 20 Apr 2006 23:31:24 -0400), Don Law <opendon@donlaw.com> says:
> One side effect of this change is that neigh_lookup is now called while > a read lock is held on neigh_tbl_lock. neigh_lookup does take read > locks on the tbl->lock set. However, this does not introduce any new lock > order dependencies, since we already have that precedent set in the > neightbl_set function.
I don't think this is good change.
What you need to fix your problem is to remove the last "goto out_dev_put;" isn't it?
--yoshfuji - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |