Messages in this thread | | | Date | Thu, 20 Apr 2006 19:33:34 +0200 | From | Nick Piggin <> | Subject | Re: [patch 1/5] mm: remap_vmalloc_range |
| |
On Thu, Apr 20, 2006 at 06:22:05PM +0100, Christoph Hellwig wrote: > On Thu, Apr 20, 2006 at 07:06:18PM +0200, Nick Piggin wrote: > > Add a remap_vmalloc_range and get rid of as many remap_pfn_range and > > vm_insert_page loops as possible. > > > > remap_vmalloc_range can do a whole lot of nice range checking even > > if the caller gets it wrong (which it looks like one or two do). > > This looks very nice, thanks!
Thank you
> Although it might be better to split it > into one patch to introduce remap_vmalloc_range and various patches to > switch over one susbsyetm for merging purposes.
Sure, if anyone insists ;)
I tend to agree. I would tend to do it in just 2 patches (1 for implementation, 1 for conversion) to make administrative overheads smaller -- the conversions are small and very well contained. Is there a good reason to split further?
Nick - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |