Messages in this thread | | | Date | Tue, 11 Apr 2006 15:17:16 -0700 | From | "Randy.Dunlap" <> | Subject | Re: [PATCH] CONSOLE_LP_STRICT Kconfig option |
| |
On Wed, 15 Feb 2006 10:03:30 +0100 Luca Falavigna wrote:
> Oops, I noticed I sent twice my email. Sorry. > > 14 Feb 2006 15:59:56 +0100, Andi Kleen <ak@suse.de>: > > This shouldn't be a CONFIG. This should be a runtime option. > > It's ridiculous to have to recompile your kernel just to fix some > > problem with your printer. > > > > e.g. sysctl, ioctl, sysfs entry, module parameter. Whatever is en > > vogue these days. Easiest would be probably a module_param(). > > This feature only gets involved when passing console=lp0 parameter to > the bootloader. I never tried to load a new system console while > system was running so I'm not sure if it behaves correctly. If it > does, I will modify this patch following your advices.
Andi's suggestion seems fine to me: use a module_param() for CONSOLE_LP_STRICT instead of a hidden build-time (non-Kconfig) option. Are you interested in making this change?
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |