Messages in this thread | | | Subject | Re: [PATCH] Don't pass offset == 0 && endbyte == 0 to do_sync_file_range() | From | OGAWA Hirofumi <> | Date | Sun, 02 Apr 2006 11:21:23 +0900 |
| |
Andrew Morton <akpm@osdl.org> writes:
>> + /* >> + * wbc->start == 0 && wbc->end == 0 is a special range, >> + * so this avoids using it. >> + */ >> + if (endbyte > 1) >> + endbyte--; /* inclusive */ >> + } > > Yes, the problem is that the interface is busted - start=0,end=0 is > ambiguous and ->writepages() will get it wrong. > > So I think it's better to fix the interface...
I agree. And I think WB_SYNC_NONE with rage would be useful. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |