Messages in this thread Patch in this message | | | Subject | Re: [patch 2.6.16-mm2 2/9] sched throttle tree extract - fix potential task uninterruptible bug | From | Mike Galbraith <> | Date | Sat, 01 Apr 2006 10:38:03 +0200 |
| |
This patch fixes a bug waiting for a place to happen should anyone ever combine TASK_NONINTERACTIVE with TASK_UNINTERRUPTIBLE.
Signed-off-by: Mike Galbraith <efault@gmx.de>
--- linux-2.6.16-mm2/kernel/sched.c-1.timewarp 2006-03-23 15:04:42.000000000 +0100 +++ linux-2.6.16-mm2/kernel/sched.c 2006-03-23 15:07:08.000000000 +0100 @@ -1457,7 +1457,7 @@ out_set_cpu: out_activate: #endif /* CONFIG_SMP */ - if (old_state == TASK_UNINTERRUPTIBLE) { + if (old_state & TASK_UNINTERRUPTIBLE) { rq->nr_uninterruptible--; /* * Tasks on involuntary sleep don't earn @@ -3167,7 +3167,7 @@ need_resched_nonpreemptible: unlikely(signal_pending(prev)))) prev->state = TASK_RUNNING; else { - if (prev->state == TASK_UNINTERRUPTIBLE) + if (prev->state & TASK_UNINTERRUPTIBLE) rq->nr_uninterruptible++; deactivate_task(prev, rq); }
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |