lkml.org 
[lkml]   [2006]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.4 patch] Corrected faulty syntax in drivers/input/Config.in
On Sat, Mar 04, 2006 at 07:44:01PM +0100, Jan Engelhardt wrote:
> >> If statement in drivers/input/Config.in for "make xconfig" corrected.
> >>
> >> Signed-off-by: Stefan-W. Hahn <stefan.hahn@s-hahn.de>
> >> Signed-off-by: Adrian Bunk <bunk@stusta.de>
> >>
> >> --- a/drivers/input/Config.in
> >> +++ b/drivers/input/Config.in
> >> @@ -8,7 +8,7 @@ comment 'Input core support'
> >> tristate 'Input core support' CONFIG_INPUT
> >> dep_tristate ' Keyboard support' CONFIG_INPUT_KEYBDEV $CONFIG_INPUT
> >>
> >> -if [ "$CONFIG_INPUT_KEYBDEV" == "n" ]; then
> >> +if [ "$CONFIG_INPUT_KEYBDEV" = "n" ]; then
> >> bool ' Use dummy keyboard driver' CONFIG_DUMMY_KEYB $CONFIG_INPUT
> >> fi
>
> If this is sh compatible code, then == is just as valid -- if xconfig

It is not.

> breaks then, then xconfig is broken, not the file.

Please read at least the section "Introduction" of
Documentation/kbuild/config-language.txt in kernel 2.4
instead of falsely accusing xconfig of being broken.

> Jan Engelhardt

cu
Adrian

--

"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-04 19:58    [W:1.579 / U:0.020 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site