Messages in this thread | | | Date | Thu, 30 Mar 2006 10:42:23 -0800 | From | Badari Pulavarty <> | Subject | Re: kernel BUG at fs/direct-io.c:916! |
| |
Nathan Scott wrote:
>On Tue, Mar 28, 2006 at 09:30:44AM -0800, Badari Pulavarty wrote: > >>Thanks for working this out. You may want to add a description >>to the patch. Like: >> >>"inode->i_blkbits should be used instead of dio->blkbits, as >>it may not indicate the filesystem block size all the time". >> > >Will do, thanks. Oh, another thing - what is the situation >where a NULL bdev would be passed into __blockdev_direct_IO? >All the filesystems seem to pass i_sb->s_bdev, so I guess it >must be blkdev_direct_IO - can I_BDEV(inode) ever be NULL on >a block device inode (doesn't sound right)? If it cannot, I >suppose we should remove those NULL bdev checks too... > >cheers. >
I can't think of a case, where we would end up getting b_dev = NULL in direct IO code.
Thanks, Badari
> >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |