Messages in this thread | | | Subject | Re: [patch 1/1] sys_sync_file_range() | From | OGAWA Hirofumi <> | Date | Fri, 31 Mar 2006 00:31:22 +0900 |
| |
Andrew Morton <akpm@osdl.org> writes:
> + if ((s64)offset < 0) > + goto out; > + if ((s64)endbyte < 0) > + goto out;
loff_t is long long on all arch. This is not need?
> + if (S_ISFIFO(file->f_dentry->d_inode->i_mode)) { > + ret = -ESPIPE; > + goto out_put; > + }
How about to check "if (!file->f_op || !file->f_op->fsync)" or something?
For chrdev is also strange, and in the case of fsync(), it returns -EINVAL. IMHO it seems there is consistency.
Thanks. -- OGAWA Hirofumi <hirofumi@mail.parknet.co.jp> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |