Messages in this thread | | | Date | Thu, 30 Mar 2006 13:55:25 +0200 | From | Jens Axboe <> | Subject | Re: [PATCH] splice support #2 |
| |
On Thu, Mar 30 2006, Andrew Morton wrote: > Jens Axboe <axboe@suse.de> wrote: > > > > > > +static void *page_cache_pipe_buf_map(struct file *file, > > > > + struct pipe_inode_info *info, > > > > + struct pipe_buffer *buf) > > > > +{ > > > > + struct page *page = buf->page; > > > > + > > > > + lock_page(page); > > > > + > > > > + if (!PageUptodate(page)) { > > > > > > || page->mapping == NULL > > > > Fixed > > Actually that wasn't right. If the page was truncated then we shouldn't > return -EIO to userspace. We should return zero, as this is the first > page.
_if_ this is the first page, then agree.
> Which means either returning an ERR_PTR here for -EIO or re-checking i_size > in the caller. Maybe the latter?
The latter sounds better, I'll add that.
-- Jens Axboe
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |