Messages in this thread | | | Date | Mon, 27 Mar 2006 19:11:11 +0200 | From | Jean Delvare <> | Subject | Re: [PATCH 2.6.16-mm1 2/3] rtc: m41t00 driver cleanup |
| |
Hi Mark,
> This patch does some cleanup to the m41t00 i2c/rtc driver including: > - use BCD2BIN/BIN2BCD instead of BCD_TO_BIN/BIN_TO_BCD > - use strlcpy instead of strncpy > - some whitespace cleanup
Looks overall good, except:
> @@ -214,6 +208,7 @@ m41t00_detach(struct i2c_client *client) > > static struct i2c_driver m41t00_driver = { > .driver = { > + .owner = THIS_MODULE, > .name = M41T00_DRV_NAME, > }, > .id = I2C_DRIVERID_STM41T00,
i2c_add_driver sets the owner for you, so it was omitted here on purpose.
I'll drop that change before pushing the patch to Greg, no need to resend.
Thanks, -- Jean Delvare - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |