lkml.org 
[lkml]   [2006]   [Mar]   [21]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 04/23] driver core: platform_get_irq*(): return -ENXIO on error
On Tue, Mar 21, 2006 at 01:13:36AM +0100, Olivier Galibert wrote:
> On Mon, Mar 20, 2006 at 02:00:38PM -0800, Greg Kroah-Hartman wrote:
> > platform_get_irq*() cannot return 0 on error as 0 is a valid IRQ on some
> > platforms, return -ENXIO instead.
>
> 0 is NO_IRQ, and can not be a valid IRQ number, ever. A
> platform_get_irq*() returning 0 as a valid irq is buggy.
>
> Check http://lkml.org/lkml/2005/11/21/211

No. That's Linus' _opinion_, which is not applicable to systems without
the obviously broken PCI or ISA busses. On such systems, IRQ0 has no
special meaning what so ever.

Greg - please continue sending this patch.

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-21 11:29    [W:0.314 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site