Messages in this thread | | | Date | Mon, 20 Mar 2006 10:46:01 +0100 | From | Jan Kara <> | Subject | Re: [PATCH] fix potential null pointer deref in quota |
| |
Hello,
> The coverity checker noticed that we may pass a NULL super_block to > do_quotactl() that dereferences it. > Dereferencing NULL pointers is bad medicine, better check and fail > gracefully. Umm, when do you think we can dereference NULL pointer to a super_block? check_quotactl_valid() allows sb==NULL only in the case of Q_SYNC command. And that is handled in do_quotactl() correctly even if sb==NULL...
Honza
-- Jan Kara <jack@suse.cz> SuSE CR Labs - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |