lkml.org 
[lkml]   [2006]   [Mar]   [20]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] scm: fold __scm_send() into scm_send()
* Ingo Oeser (netdev@axxeo.de) wrote:
> Hi Chris,
>
> Andrew Morton wrote:
> > Ingo Oeser <ioe-lkml@rameria.de> wrote:
> > >
> > > -int scm_send(struct socket *sock, struct msghdr *msg, struct scm_cookie *scm)
> > > -{
> > > - struct task_struct *p = current;
> > > - scm->creds = (struct ucred) {
> > > - .uid = p->uid,
> > > - .gid = p->gid,
> > > - .pid = p->tgid
> > > - };
> > > - scm->fp = NULL;
> > > - scm->sid = security_sk_sid(sock->sk, NULL, 0);
> > > - scm->seq = 0;
> > > - if (msg->msg_controllen <= 0)
> > > - return 0;
> > > - return __scm_send(sock, msg, scm);
> > > -}
> >
> > It's worth noting that scm_send() will call security_sk_sid() even if
> > (msg->msg_controllen <= 0).
>
> Chris, do you know if this is needed in this case?

This whole thing is looking broken. I'm still trying to find the original
patch which caused the series of broken patches on top.

thanks,
-chris
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-20 21:21    [W:1.096 / U:0.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site