Messages in this thread | | | From | Oliver Neukum <> | Subject | Re: [PATCH]use kzalloc in vfs where appropriate | Date | Mon, 20 Mar 2006 13:52:52 +0100 |
| |
> > Rewriting the test as: > > n!=0 && n > INT_MAX / size > > saves the division because size is much likelier to be a constant, and indeed > > the code is better: > > > > cmpq $268435455, %rax > > movq $0, 40(%rsp) > > ja .L313 > > > > Is there anything I am missing? > > Did you check allyesconfig vmlinux size before and after? If it helps, > like it probably does, post a patch!
Hi Pekka,
it saves 18K of 232M. I am making a patch.
Regards Oliver - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |