lkml.org 
[lkml]   [2006]   [Mar]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    Patch in this message
    /
    From
    Subject[PATCH 10/15] EDAC: edac_mc_add_mc() fix [1/2]
    Date
    This is part 1 of a 2-part patch set.  The code changes are split into
    two parts to make the patches more readable.

    Move complete_mc_list_del() and del_mc_from_global_list() so we can
    call del_mc_from_global_list() from edac_mc_add_mc() without forward
    declarations. Perhaps using forward declarations would be better?
    I'm doing things this way because the rest of the code is missing
    them.

    Signed-Off-By: David S. Peterson <dsp@llnl.gov> <dave_peterson@pobox.com>
    ---

    Index: linux-2.6.16-rc5-edac/drivers/edac/edac_mc.c
    ===================================================================
    --- linux-2.6.16-rc5-edac.orig/drivers/edac/edac_mc.c 2006-02-27 17:05:48.000000000 -0800
    +++ linux-2.6.16-rc5-edac/drivers/edac/edac_mc.c 2006-02-27 17:06:17.000000000 -0800
    @@ -1405,6 +1405,24 @@ static int add_mc_to_global_list (struct
    }


    +static void complete_mc_list_del (struct rcu_head *head)
    +{
    + struct mem_ctl_info *mci;
    +
    + mci = container_of(head, struct mem_ctl_info, rcu);
    + INIT_LIST_HEAD(&mci->link);
    + complete(&mci->complete);
    +}
    +
    +
    +static void del_mc_from_global_list (struct mem_ctl_info *mci)
    +{
    + list_del_rcu(&mci->link);
    + init_completion(&mci->complete);
    + call_rcu(&mci->rcu, complete_mc_list_del);
    + wait_for_completion(&mci->complete);
    +}
    +

    EXPORT_SYMBOL(edac_mc_add_mc);

    @@ -1466,24 +1484,6 @@ finish:
    }


    -
    -static void complete_mc_list_del (struct rcu_head *head)
    -{
    - struct mem_ctl_info *mci;
    -
    - mci = container_of(head, struct mem_ctl_info, rcu);
    - INIT_LIST_HEAD(&mci->link);
    - complete(&mci->complete);
    -}
    -
    -static void del_mc_from_global_list (struct mem_ctl_info *mci)
    -{
    - list_del_rcu(&mci->link);
    - init_completion(&mci->complete);
    - call_rcu(&mci->rcu, complete_mc_list_del);
    - wait_for_completion(&mci->complete);
    -}
    -
    EXPORT_SYMBOL(edac_mc_del_mc);

    /**
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/
    \
     
     \ /
      Last update: 2006-03-03 02:52    [W:7.894 / U:0.084 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site