Messages in this thread | | | Date | Fri, 03 Mar 2006 08:52:29 +1300 | From | Sam Vilain <> | Subject | Re: [Fwd: [PATCH 3/5] NFS: Abstract out namespace initialisation [try #2]] |
| |
David Howells wrote: > Christoph Hellwig <hch@infradead.org> wrote: >>>The attached patch abstracts out the namespace initialisation so that >>>temporary namespaces can be set up elsewhere. >>Definitily shouldb't be inline. And until you have a second caller >>it's utterly pointless. So NACK for now. > I presume from that you didn't notice that the second caller was in patch 5/5?
AIUI, each patch must stand on its own in every regard. I guess you need to make it inline in the later patch - or not at all given the marginal speed difference vs. core size increase.
Sam. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |