Messages in this thread | | | Date | Sat, 18 Mar 2006 16:53:02 -0800 | From | Andrew Morton <> | Subject | Re: OOPS: 2.6.16-rc6 cpufreq_conservative |
| |
Linus Torvalds <torvalds@osdl.org> wrote: > > Gaah. Looking at the assembly code to try to figure out where the oops > happened, one thing is clear: "for_each_cpu_mask()" generates some truly > horrible code. C code that looks simple ends up being tons of complex > assembly language due to inline functions etc. > > We've made it way too easy for people to write code that just absolutely > _sucks_.
Yes, uninlining merely first_cpu() shrinks my usual vmlinux by 2.5k. I'll fix it up.
Meanwhile, I suppose we need to check that pointer for NULL as Parag suggests. I might stick a once-off WARN_ON() in there so someone gets in and works out why we keep on having to graft mysterious null-pointer avoidances into cpufreq.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |