Messages in this thread Patch in this message | | | Date | Wed, 15 Mar 2006 17:33:01 +0300 | From | Alexey Dobriyan <> | Subject | Re: PATCH: rio driver rework continued #2 |
| |
On Wed, Mar 15, 2006 at 12:27:36PM +0000, Alan Cox wrote: > First large chunk of code cleanup. The split between this and #3 and #4 > is fairly arbitary and due to the message length limit on the list. > These patches continue the process of ripping out macros and typedefs > while cleaning up lots of 32bit assumptions. Several inlines for > compatibility also get removed and that causes a lot of noise.
> --- linux.vanilla-2.6.16-rc6-mm1/drivers/char/rio/rioparam.c > +++ linux-2.6.16-rc6-mm1/drivers/char/rio/rioparam.c > @@ -247,7 +240,7 @@ > } > > rio_dprintk(RIO_DEBUG_PARAM, "can_add_transmit() returns %x\n", res); > - rio_dprintk(RIO_DEBUG_PARAM, "Packet is 0x%x\n", (int) PacketP); > + rio_dprintk(RIO_DEBUG_PARAM, "Packet is 0x%p\n", PacketP); ^^^^
Just %p.
> @@ -466,10 +459,10 @@ > rio_dprintk(RIO_DEBUG_TTY, "port close SysPort %d\n", PortP->PortNum); > > /* PortP = p->RIOPortp[SysPort]; */ > - rio_dprintk(RIO_DEBUG_TTY, "Port is at address 0x%x\n", (int) PortP); > + rio_dprintk(RIO_DEBUG_TTY, "Port is at address 0x%p\n", PortP); > /* tp = PortP->TtyP; *//* Get tty */ > tty = PortP->gs.tty; > - rio_dprintk(RIO_DEBUG_TTY, "TTY is at address 0x%x\n", (int) tty); > + rio_dprintk(RIO_DEBUG_TTY, "TTY is at address 0x%p\n", tty);
Ditto.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |