Messages in this thread | | | Subject | Re: [PATCH] fix alloc_large_system_hash roundup | From | Roland Dreier <> | Date | Wed, 15 Mar 2006 10:41:58 -0800 |
| |
Kenneth> roundup_pow_of_two uses fls, but fls takes an "int" Kenneth> argument. I think that function is buggy on 64-bit Kenneth> arch. Is it an oversight or something?
Huh, looks like you're right. I never looked inside fls() before. Yes, roundup_pow_of_two() should probably be fixed, since a naive person (like me) would look at it and think it works on longs.
- R. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |