lkml.org 
[lkml]   [2006]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [RFC][PATCH] Expanding the size of "start" and "end" field in "struct resource"
Date

On Mar 15, 2006, at 2:53 PM, Benjamin LaHaise wrote:

> On Wed, Mar 15, 2006 at 02:31:14PM -0500, Vivek Goyal wrote:
>> Is there a reason why "start" and "end" field of "struct resource"
>> are of
>> type unsigned long. My understanding is that "struct resource" can
>> be used
>> to represent any system resource including physical memory. But
>> unsigned
>> long is not suffcient to represent memory more than 4GB on PAE
>> systems.
>> and compiler starts throwing warnings.
>
> Please make this depend on the kernel being compiled with PAE. We
> don't
> need to bloat 32 bit kernels needlessly.

I disagree. I think we need to look to see what the "bloat" is
before we go and make start/end config dependent.

It seems clear that drivers dont handle the fact that "start"/"end"
change an 32-bit vs 64-bit archs to begin with. By making this even
more config dependent seems to be asking for more trouble.

- kumar
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-03-15 23:09    [W:0.450 / U:0.480 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site