Messages in this thread Patch in this message | | | Date | Wed, 15 Mar 2006 14:44:01 +0800 | From | Eugene Teo <> | Subject | Re: Fix hostap_cs double kfree |
| |
<quote sender="Jouni Malinen"> > On Wed, Mar 15, 2006 at 10:39:00AM +0800, Eugene Teo wrote: > > prism2_config() kfree's twice if kmalloc fails. > > > > Coverity bug #930 > > Thanks. I'm going through the issues related to Host AP driver in > Coverity database and send a set of patches after some testing.
Ok, here's a resend. Thanks.
Eugene
-- prism2_config() kfree's twice if kmalloc fails.
Coverity bug #930
Signed-off-by: Eugene Teo <eugene.teo@eugeneteo.net>
--- linux-2.6/drivers/net/wireless/hostap/hostap_cs.c~ 2006-03-15 10:05:36.000000000 +0800 +++ linux-2.6/drivers/net/wireless/hostap/hostap_cs.c 2006-03-15 14:38:54.000000000 +0800 @@ -585,8 +585,6 @@ parse = kmalloc(sizeof(cisparse_t), GFP_KERNEL); hw_priv = kmalloc(sizeof(*hw_priv), GFP_KERNEL); if (parse == NULL || hw_priv == NULL) { - kfree(parse); - kfree(hw_priv); ret = -ENOMEM; goto failed; } -- 1024D/A6D12F80 print D51D 2633 8DAC 04DB 7265 9BB8 5883 6DAA A6D1 2F80 main(i) { putchar(182623909 >> (i-1) * 5&31|!!(i<7)<<6) && main(++i); } - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |