Messages in this thread | | | Date | Sun, 12 Mar 2006 03:04:35 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH 2/8] [I/OAT] Driver for the Intel(R) I/OAT DMA engine |
| |
Evgeniy Polyakov <johnpol@2ka.mipt.ru> wrote: > > On Fri, Mar 10, 2006 at 06:29:46PM -0800, Leech, Christopher (christopher.leech@intel.com) wrote: > > From: Chris Leech [mailto:christopher.leech@intel.com] > > Sent: Friday, March 10, 2006 6:29 PM > > To: > > Subject: [PATCH 2/8] [I/OAT] Driver for the Intel(R) I/OAT DMA engine > > > > > > Adds a new ioatdma driver > > enumerate_dma_channels() is still broken, if it can not fail add NOFAIL > gfp flag.
The __GFP_NOFAIL flag is there to mark lame-and-buggy-code which doesn't know how to handle ENOMEM. I went through the kernel, found all the retry-until-it-works loops and consolidated their behaviour in the page allocator instead.
Really we should fix them all up. Adding new users of __GFP_NOFAIL would not be good. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |