Messages in this thread | | | Date | Thu, 9 Feb 2006 18:58:55 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] Support HDIO_GETGEO on device-mapper volumes |
| |
"Darrick J. Wong" <djwong@us.ibm.com> wrote: > > The attached patch implements a simple ioctl handler that supplies a > compatible geometry when HDIO_GETGEO is called against a device-mapper > device.
block_device_operations now has a standalone `getgeo' method.
> ... > +static int dm_blk_ioctl(struct inode * inode, struct file * filp, > + unsigned int cmd, unsigned long arg) > +{ > + struct block_device *bdev = inode->i_bdev; > + struct hd_geometry __user *loc = (void __user *)arg; > + struct mapped_device *md; > + int diskinfo[4]; > + > + if (cmd == HDIO_GETGEO) { > + if (!arg) > + return -EINVAL;
I don't think we need that check? The -EFAULT should suffice. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |