Messages in this thread | | | Date | Wed, 8 Feb 2006 13:35:41 +0100 | From | Holger Eitzenberger <> | Subject | Re: [patch 6/6] [NETFILTER]: Fix another crash in ip_nat_pptp (CVE-2006-0037) |
| |
On Fri, Jan 27, 2006 at 06:18:35PM -0800, Greg KH wrote:
> DEBUGP("altering call id from 0x%04x to 0x%04x\n", > - ntohs(*cid), ntohs(new_callid)); > + ntohs(*(u_int16_t *)pptpReq + cid_off), ntohs(new_callid));
Note that this fix introduces another bug in the above use DEBUGP statement, as there is (u_int16_t *) ptr arithmetic used, whereas cid_off is a byte offset.
A fix for that was send a few weeks ago on netfilter-devel.
/holger
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |