Messages in this thread | | | Date | Wed, 08 Feb 2006 05:08:34 +0400 | From | Manu Abraham <> | Subject | Re: [PATCH 04/16] Fix [Bug 5895] to correct snd_87x autodetect |
| |
Edgar Toernig wrote: > mchehab@infradead.org wrote: > >> --- a/drivers/media/dvb/bt8xx/bt878.c >> +++ b/drivers/media/dvb/bt8xx/bt878.c >> @@ -381,6 +381,23 @@ bt878_device_control(struct bt878 *bt, u >> >> EXPORT_SYMBOL(bt878_device_control); >> >> + >> +struct cards card_list[] __devinitdata = { >> + >> + { 0x01010071, BTTV_BOARD_NEBULA_DIGITV, "Nebula Electronics DigiTV" }, >> + { 0x07611461, BTTV_BOARD_AVDVBT_761, "AverMedia AverTV DVB-T 761" }, >> [...] >> > > I'm not very familiar with the pci configuration logic but > what's the point of this list and the BTTV_BOARD_xxx defines? > The defines are never used and the list is only used to let > the probe routine fail when the device is not in the list. >
Yes, that's the idea. The naming is for identification in the failed case.
> Anyway, the bttv driver already has this information in his card > list (field has_dvb). As long as the bt878 isn't stand alone > and requires the bttv driver wouldn't it be better to query its > table? > >
This is only the interim fix for bug [5895] prior to the merge, as was discussed on the linux-dvb and video4linux mailing lists. Thread: [linux-dvb] Re: [Fwd: [Bug 5895] With DVB drivers enabled snd_87x (ALSA) don't detect Broooktree audio]
> Even if this table is kept, it should be static >
Ack'd.
Thanks, Manu
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |