Messages in this thread | | | Date | Tue, 07 Feb 2006 15:01:30 -0800 | From | Haren Myneni <> | Subject | Re: [PATCH] Fix in free initrd when overlapped with crashkernel region |
| |
Paul Mackerras wrote:
>Haren Myneni writes: > > > >>--- 2616-rc2.orig/include/linux/kexec.h 2006-02-06 19:08:01.000000000 -0800 >>+++ 2616-rc2/include/linux/kexec.h 2006-02-06 19:06:37.000000000 -0800 >>@@ -6,6 +6,7 @@ >> #include <linux/list.h> >> #include <linux/linkage.h> >> #include <linux/compat.h> >>+#include <linux/ioport.h> >> #include <asm/kexec.h> >> >> > >What's this hunk for? > >Paul. > >
crashk_res is an extern declaration in kexec.h. Declared as "struct resource" which is defined in linux/ioport.h. For other places wherever this variable is used, ioport.h got included through some other header file. Whereas for initramfs.c, either we need to include ioport.h explicitly or include in kexec.h. Chosen the later one. Probably, some comment would be better to make it clear.
Paul, do you prefer to repost the patch with the comment?
Thanks Haren
>- >To unsubscribe from this list: send the line "unsubscribe linux-kernel" in >the body of a message to majordomo@vger.kernel.org >More majordomo info at http://vger.kernel.org/majordomo-info.html >Please read the FAQ at http://www.tux.org/lkml/ > > >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |