Messages in this thread Patch in this message | | | Subject | Re: [PATCH] spi: Fix modular master driver remove and device suspend/remove | From | Stephen Street <> | Date | Tue, 07 Feb 2006 13:35:25 -0800 |
| |
On Tue, 2006-02-07 at 08:03 +0000, Russell King wrote: > On Mon, Feb 06, 2006 at 07:04:11PM -0800, stephen@streetfiresound.com wrote: > > --- linux-2.6.16-rc2/drivers/spi/spi.c 2006-02-06 18:39:31.746537258 -0800 > > +++ linux-spi/drivers/spi/spi.c 2006-02-06 18:39:45.353334421 -0800 > > @@ -90,7 +90,7 @@ static int spi_suspend(struct device *de > > int value; > > struct spi_driver *drv = to_spi_driver(dev->driver); > > > > - if (!drv->suspend) > > + if (!drv || !drv->suspend) > > Shouldn't this be dev->driver ? If dev->driver is NULL, drv may be > non-NULL due to an offset in the structure. > If I understand your comment correctly, the implementation of to_spi_drv protects against this by returning NULL if dev->driver is NULL. This is implementation dependent and I can make the test explicit if you want?
-Stephen
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |