Messages in this thread | | | Subject | Re: [PATCH, RFC] Driver for reading HP laptop LCD brightness | From | Arjan van de Ven <> | Date | Sun, 05 Feb 2006 15:27:26 +0100 |
| |
On Sun, 2006-02-05 at 13:55 +0000, Matthew Garrett wrote: > + if (enable==0) { > + return snprintf(buf, PAGE_SIZE, "NA\n"); > + } > + > + disable_irq(8); > + > + outb(0x97, 0x72); > + value = inb(0x73); > + > + enable_irq(8); > +
disable_irq() and enable_irq() are really really evil. Are you sure you need these? To me on first sight it looks like a bug (think of shared interrupts for example), can you explain what you are trying to achieve with these?
Greetings, Arjan van de Ven
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |