Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [ 00/10] [Suspend2] Modules support. | Date | Sat, 4 Feb 2006 18:18:56 +0100 |
| |
Hi,
On Saturday 04 February 2006 12:41, Nigel Cunningham wrote: > On Saturday 04 February 2006 21:38, Rafael J. Wysocki wrote: > > > > My personal view is that: > > > > 1) turning the freezing of kernel threads upside-down is not > > > > necessary and would cause problems in the long run, > > > > > > Upside down? > > > > I mean now they should freeze voluntarily and your patches change that > > so they would have to be created as non-freezeable if need be, AFAICT. > > Ah. Now I'm on the same page. Lost the context. > > > > > 2) the todo lists are not necessary and add a lot of complexity, > > > > > > Sorry. Forgot about this. I liked it for solving the SMP problem, but > > > IIRC, we're downing other cpus before this now, so that issue has gone > > > away. I should check whether I'm right there. > > > > > > > 3) trying to treat uninterruptible tasks as non-freezeable should > > > > better be avoided (I tried to implement this in swsusp last year but > > > > it caused vigorous opposition to appear, and it was not Pavel ;-)) > > > > > > I'm not suggesting treating them as unfreezeable in the fullest sense. > > > I still signal them, but don't mind if they don't respond. This way, > > > if they do leave that state for some reason (timeout?) at some point, > > > they still get frozen. > > > > Yes, that's exactly what I wanted to do in swsusp. ;-) > > Oh. What's Pavel's solution? Fail freezing if uninterruptible threads don't > freeze?
Yes.
AFAICT it's to avoid situations in which we would freeze having a process in the D state that holds a semaphore or a mutex neded for suspending or resuming devices (or later on for saving the image etc.).
[I didn't answer this question previously, sorry.]
Greetings, Rafael - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |