lkml.org 
[lkml]   [2006]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/5] cpuset memory spread slab cache implementation
On Sat, 4 Feb 2006, Andrew Morton wrote:

> Paul Jackson <pj@sgi.com> wrote:
> >
> > + if (unlikely(cpuset_mem_spread_check() &&
> > + (cachep->flags & SLAB_MEM_SPREAD) &&
> > + !in_interrupt())) {
> > + int nid = cpuset_mem_spread_node();
> > +
> > + if (nid != numa_node_id())
> > + return __cache_alloc_node(cachep, flags, nid);
> > + }
>
> Need a comment here explaining the mysterious !in_interrupt() check.

If we are in interrupt context then the current pointer may not be
meaningful. cpuset settings should not be applied for any memory
allocation.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-05 04:40    [W:0.075 / U:0.708 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site