lkml.org 
[lkml]   [2006]   [Feb]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] Vectorize aio_read/aio_write methods
Christoph Hellwig wrote:
> do {
> - ret = file->f_op->aio_read(iocb, iocb->ki_buf,
> - iocb->ki_left, iocb->ki_pos);
> + struct iovec iov = {
> + .iov_base = iocb->ki_buf,
> + .iov_len = iocb->ki_left
> + };
> +
> + ret = file->f_op->aio_read(iocb, &iov, 1, iocb->ki_pos);
>
> this still has the lifetime problems Ben pointed out. aio might still
> be outstanding when this thread returned to userspace, so we need to
> dynamically allocated the iovec and free it later. (or make it part
> of the iocb?)

I left that intentionally alone. I was planning to make it a
special case of Zach's vector IO handling code.


Thanks,
Badari



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-04 23:12    [W:0.038 / U:0.588 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site