Messages in this thread | | | Date | Sat, 04 Feb 2006 14:10:10 -0800 | From | Badari Pulavarty <> | Subject | Re: [PATCH 1/3] Vectorize aio_read/aio_write methods |
| |
Christoph Hellwig wrote: > do { > - ret = file->f_op->aio_read(iocb, iocb->ki_buf, > - iocb->ki_left, iocb->ki_pos); > + struct iovec iov = { > + .iov_base = iocb->ki_buf, > + .iov_len = iocb->ki_left > + }; > + > + ret = file->f_op->aio_read(iocb, &iov, 1, iocb->ki_pos); > > this still has the lifetime problems Ben pointed out. aio might still > be outstanding when this thread returned to userspace, so we need to > dynamically allocated the iovec and free it later. (or make it part > of the iocb?)
I left that intentionally alone. I was planning to make it a special case of Zach's vector IO handling code.
Thanks, Badari
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |