Messages in this thread | | | Date | Tue, 28 Feb 2006 13:04:18 +0100 | From | Pavel Machek <> | Subject | Re: [PATCH 2/13] ATA ACPI: debugging infrastructure |
| |
On Út 28-02-06 07:00:14, Jeff Garzik wrote: > Pavel Machek wrote: > >I hate to see debugging infrastructure like this. We already have it > >in ACPI and it is nasty/useless. It hides serious errors during normal > >run, while if you turn on the debugging, it floods logs so that > >it is unusable, too. I end up having to replace dprintks with > >printks... nasty. > > Then you clearly don't understand what the code is doing. > Fine-grained
No, I do not... code is so full of printk()s that it is unreadable.
> message selection allows one to turn on only the messages needed, and > only for the controller desired. Otherwise, it is nearly impossible to > debug one SATA controller while booting off another.
Now, maybe message selection is neccessary, but having printk at begining of each function is not way to go. Pavel
-- Web maintainer for suspend.sf.net (www.sf.net/projects/suspend) wanted... - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |