Messages in this thread | | | Subject | Re: udevd is killing file write performance. | From | John McCutchan <> | Date | Sun, 26 Feb 2006 11:58:49 -0500 |
| |
On Fri, 2006-24-02 at 18:19 +1100, Nick Piggin wrote: > Andrew Morton wrote: > > Nick Piggin <nickpiggin@yahoo.com.au> wrote: > > > >>@@ -538,7 +579,7 @@ void inotify_dentry_parent_queue_event(s > >> struct dentry *parent; > >> struct inode *inode; > >> > >> - if (!atomic_read (&inotify_watches)) > >> + if (!(dentry->d_flags & DCACHE_INOTIFY_PARENT_WATCHED)) > > > > > > Yeah, I think that would work. One would need to wire up d_move() also - > > for when a file is moved from a watched to non-watched directory and > > vice-versa. > > > > > > Oh yeah of course, good catch. Are there any other cases missing? > > ... I'll let the others on this thread digest before spitting out > another patch. > > John or Robert, is there some kind of inotify test suite around?
Unfortunately there isn't. In the past gamin's test suite was a good start, but it hasn't been working for a while now.
-- John McCutchan <john@johnmccutchan.com> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |