Messages in this thread | | | Date | Sun, 26 Feb 2006 16:55:49 -0700 | From | Matthew Wilcox <> | Subject | Re: [2.6 patch] drivers/pci/hotplug/cpqphp_ctrl.c: board_replaced(): remove dead code |
| |
On Sun, Feb 26, 2006 at 10:16:51PM +0100, Adrian Bunk wrote: > he Coverity checker correctly noted, that in function board_replaced in > drivers/pci/hotplug/cpqphp_ctrl.c, the variable src always has the > value 8, and therefore much code after the > > ... > if (rc || src) { > ... > if (rc) > return rc; > else > return 1; > } > ... > > > can never be called. > > This patch removes the unreachable code in this function fixing kernel > Bugzilla #6073.
It seems much more likely to me that the '|| src' indicates a bug, and the unreachable code should have been reached. Why not cc the maintainer for his opinion? - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |