lkml.org 
[lkml]   [2006]   [Feb]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: 2.6.16-rc4-mm2: drivers/rtc/utils.c should become part of a generic implementation
On Sun, Feb 26, 2006 at 07:55:18PM +0100, Adrian Bunk wrote:
> On Sun, Feb 26, 2006 at 07:41:16PM +0100, Alessandro Zummo wrote:
> > On Sat, 25 Feb 2006 14:10:25 +0100
> > Adrian Bunk <bunk@stusta.de> wrote:
> >
> > >
> > > Sounds good, but for generic functions, two adjustments are required:
> > > - move the code to lib/
> > > - remove rtc_ prefixes from the functions
> >
> > Moved. I'm not sure about renaming them..
> >
> > the functions are:
> >
> > rtc_month_days
> > rtc_time_to_tm
> > rtc_valid_tm
> > rtc_tm_to_time
> >
> > I think they make more sense with the rtc prefix
>
> None of these functions is in any way specicific to RTC drivers.

Doesn't having them take a struct rtc_time (which is different from
struct tm) make them rather RTC specific?

--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-02-26 21:04    [W:0.099 / U:0.072 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site