Messages in this thread | | | Date | Sat, 25 Feb 2006 10:13:18 +0000 | From | Al Viro <> | Subject | Re: [PATCH] flags parameter for linkat |
| |
On Sat, Feb 25, 2006 at 09:16:07AM +0000, Christoph Hellwig wrote: > Please stop adding these crappy flags argument everywhere, they're also > creaping like a cancer through the other *at stuff. Just make linkat > do the righ thing per posix spec for link, and then you can implement > a posix link based on it in glibc if the user compiles with XOPEN_SOURCE > or whatever.
It's a bloody bad idea, since XOPEN_SOURCE is nowhere near fine-grained enough and could be forced by any number of things.
The _real_ issue with flags is the lack of filtering. I.e. we blindly pass userland argument there, exposing both internal flag values _and_ flags that really shouldn't be exposed that way at all. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |