Messages in this thread | | | Date | Sat, 25 Feb 2006 21:22:48 +0000 | From | Russell King <> | Subject | Re: [PATCH 3/7] inflate pt1: clean up input logic |
| |
On Sat, Feb 25, 2006 at 03:04:54PM -0600, Matt Mackall wrote: > On Sat, Feb 25, 2006 at 06:05:21PM +0000, Russell King wrote: > > It seems that you're missing this case - the case where lib/inflate.c > > is used elsewhere in the kernel apart from the boot time decompressors. > > I think you must be getting confused with lib/zlib. lib/inflate.c is > only used at boot.
No I'm not. Look:
$ grep -r '#include.*lib/inflate.c' [a-z]* arch/alpha/boot/misc.c:#include "../../../lib/inflate.c" arch/arm/boot/compressed/misc.c:#include "../../../../lib/inflate.c" arch/arm26/boot/compressed/misc.c:#include "../../../../lib/inflate.c" arch/cris/arch-v10/boot/compressed/misc.c:#include "../../../../../lib/inflate.c" arch/cris/arch-v32/boot/compressed/misc.c:#include "../../../../../lib/inflate.c" arch/i386/boot/compressed/misc.c:#include "../../../../lib/inflate.c" arch/m32r/boot/compressed/misc.c:#include "../../../../lib/inflate.c" arch/sh/boot/compressed/misc.c:#include "../../../../lib/inflate.c" arch/sh64/boot/compressed/misc.c:#include "../../../../lib/inflate.c" arch/x86_64/boot/compressed/misc.c:#include "../../../../lib/inflate.c"
All these are to do with decompressing a compressed kernel. If they fail, halting is perfectly reasonable because we probably don't have an executable kernel. Your arguments are fine for these. But, that's not the full story - there are two more places where this code is used:
init/do_mounts_rd.c:#include "../lib/inflate.c" init/initramfs.c:#include "../lib/inflate.c"
for these your arguments that halting is fine is _NOT_ correct nor is it desirable. The first of these is the cause of the problems both myself and others saw, as detailed in the URL I posted previously in this thread. Did you read that post?
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |