Messages in this thread | | | Date | Sat, 25 Feb 2006 10:09:54 -0800 | From | "Randy.Dunlap" <> | Subject | Re: [PATCH] Fix topology.c location |
| |
On Sat, 25 Feb 2006 09:28:38 -0800 Zachary Amsden wrote:
> Dave Jones wrote: > > >This change breaks x86-64 compiles, as it uses the same file. > > > > > > Thanks for fixing that. Have we decided that file sharing of this sort > is a really bad idea yet? I still see early_printk and pci-direct.h > sharing remains. If this sharing really must go on, isn't there a less > ad-hoc way to do it? Or at least a mention in the file that "before you > modify, note this is shared by arch foo".
I guess a note would be OK, but there are notes already in Makefile*. oh, or in some .c file if it does #include another.c or #include ../../arch/other/blah
For i386 and x86_64, currently almost any file could be shared, except for the cpu-specific ones.
One hurdle to get over seems to be what would Andi accept.
--- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |