Messages in this thread | | | Date | Wed, 22 Feb 2006 06:57:19 +0100 | From | Sam Ravnborg <> | Subject | Re: [RFC] duplicate #include check for build system |
| |
On Wed, Feb 22, 2006 at 01:11:53AM +0100, Herbert Poetzl wrote: > > > > Keeping the 'what it needs' part small is a challenge resulting in > > smaller .h files. But also a good way to keep related things together. > > glad that I stimulated a philosophical discussion > about the kernel header files and what they should > include or not ... > > but the idea was more to give the developers an > instrument to verify that they are not including > stuff several times, and that's actually in .h > and .c files, because it seems that often the same > header file is included twice in the _same_ file > > anyway, was this a positive or negative reply?
If you can restrict the tool to locate the cases where a header file is included twice in the same file - then this is a positive reply. If you limit the check to the top-level file this is fine, but I would not be suprised is one or a few .h files has duplicated includes too.
Sam - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |