lkml.org 
[lkml]   [2006]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [dm-devel] Re: [PATCH] User-configurable HDIO_GETGEO for dm volumes
From
Date
Looks good and tests ok, with one issue: I still have a preference for
returning -ENOTTY over 0/0/0 when dm doesn't know the geometry. That
said, most programs will see the zero cylinder count and make a guess,
so it probably doesn't matter.

If you're happy with it, I say put it in. Thanks for the cleanup, by
the way!

--Darrick

On Wed, 2006-02-22 at 22:32 +0000, Alasdair G Kergon wrote:
> On Fri, Feb 17, 2006 at 04:59:58PM -0800, Darrick J. Wong wrote:
> > Here's the third revision, with the geometry pushed into mapped_device
> > as well as fixes for the problems that you pointed out wrt string
> > passing, lack of warning messages, etc. Thanks for all the great feedback!
>
> Almost there now: how does the version below look?
> Corresponding userspace changes are in device-mapper CVS.
>
> Alasdair
[unhandled content-type:application/pgp-signature]
\
 
 \ /
  Last update: 2006-02-23 01:49    [W:0.082 / U:0.344 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site