Messages in this thread | | | Date | Tue, 21 Feb 2006 10:36:33 +0000 | From | Christoph Hellwig <> | Subject | Re: [PATCH] altix: export sn_pcidev_info_get |
| |
On Mon, Feb 20, 2006 at 08:47:10PM -0600, Mark Maule wrote: > On Mon, Feb 20, 2006 at 08:17:14PM +0000, Christoph Hellwig wrote: > > On Tue, Feb 14, 2006 at 10:23:37AM -0600, Mark Maule wrote: > > > Export sn_pcidev_info_get. > > > > Tony or Andrew please back this out again. The only reason SGI wants this is > > to support their illegal graphics driver, and no core code uses it. > > > > And Mark, please stop submitting such patches. > > All I'm doing by exporting sn_pcidev_info_get is allowing a module to use > the SGI SN_PCIDEV_BUSSOFT() macro which will tell a driver which piece of > altix PCI hw its device is sitting behind (e.g. PCIIO_ASIC_TYPE_TIOCP et. al).
And that's absolutely not something a driver should care about. If you illegal binary driver uses it it's totally broken (but then we knew that before anyway ;-))
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |