Messages in this thread | | | Date | Mon, 20 Feb 2006 17:02:06 -0800 | From | Andrew Morton <> | Subject | Re: [2.6 patch] mm/slab: unexport kmem_cache_alloc_node |
| |
Adrian Bunk <bunk@stusta.de> wrote: > > I didn't find any modular usage of kmem_cache_alloc_node. > > Signed-off-by: Adrian Bunk <bunk@stusta.de> > > --- > > This patch was already sent on: > - 27 Jul 2005 > - 2 Jul 2005 > - 21 Jun 2005 > - 30 May 2005 > - 15 May 2005 > > --- linux-2.6.11-mm1-full/mm/slab.c.old 2005-03-06 15:40:38.000000000 +0100 > +++ linux-2.6.11-mm1-full/mm/slab.c 2005-03-06 15:41:06.000000000 +0100 > @@ -2431,7 +2440,6 @@ > __builtin_return_address(0)); > return objp; > } > -EXPORT_SYMBOL(kmem_cache_alloc_node); > > #endif >
kmem_cache_alloc_node() is part of the slab API and it is reasonable that it be exported in this manner along with the rest of that API. If someone wanted to use kmem_cache_alloc_node() and found it wasn't exported like the rest of the slab functions, that would look weird.
So I don't think we need bother going through the drawn-out pain of retracting an export which has been in-tree for a year or so.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |