Messages in this thread | | | Date | Thu, 2 Feb 2006 09:59:10 +0000 | From | Russell King <> | Subject | Re: Purpose of MMC_DATA_MULTI? |
| |
On Thu, Feb 02, 2006 at 10:49:51AM +0100, Pierre Ossman wrote: > Russell King wrote: > >In short, it's defined to be whatever AT91_MCI_TRTYP_MULTIPLE means in > >the AT91RM9200 MMC host driver, which appears to be set for any of the > >multiple block commands. They currently are doing: > > That's a bit fuzzy and bound to give problems. Why not settle for the > first case and change their code to check the block count in the > request?
Mainly because I don't know if that's sufficient, and until I get around to finding and reading the AT91RM9200 data sheet, I won't know if it is. What I do know is that the addition of that flag provides the exact information which the driver wants.
> >and using that as a lookup table by command for the value to put into > >the command register. I want to eliminate that, and not passing the > >MULTI flag prevents elimination of this table. > > Seems to be a common theme in the more recent drivers. Don't they teach > people proper layering in the schools anymore? :)
From the evidence to date, it would appear not.
-- Russell King Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/ maintainer of: 2.6 Serial core - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |