Messages in this thread | | | Date | Thu, 02 Feb 2006 21:31:26 +0000 | From | Andy Whitcroft <> | Subject | Re: [PATCH] xquad_portio fix declaration missmatch |
| |
Alexey Dobriyan wrote: > On Thu, Feb 02, 2006 at 12:43:06AM +0000, Andy Whitcroft wrote: > >>xquad_portio fix declaration missmatch > > >> arch/i386/boot/compressed/misc.c:125: error: static declaration of >> 'xquad_portio' follows non-static declaration >> include/asm/io.h:315: error: previous declaration of 'xquad_portio' was here > > >>--- reference/arch/i386/boot/compressed/misc.c >>+++ current/arch/i386/boot/compressed/misc.c >>@@ -122,7 +122,7 @@ static int vidport; >> static int lines, cols; >> >> #ifdef CONFIG_X86_NUMAQ >>-static void * xquad_portio = NULL; >>+void * xquad_portio = NULL; >> #endif > > > Can you explain why it should stay in misc.c?
Indeed it does feel like it should be a numaq special in the numaq specific files. I'll spin that and test it and see if there is a reason why its _not_ like that already.
-apw - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |