Messages in this thread | | | Subject | Re: [PATCH 2/2] fix file counting | From | Arjan van de Ven <> | Date | Sat, 18 Feb 2006 13:31:30 +0100 |
| |
On Sat, 2006-02-18 at 12:14 +0000, Christoph Hellwig wrote: > > > - Make the get_max_files export use _GPL - only unix.ko uses it. > > The real question is, does af_unix really need to allow beeing built > modular? It's quite different from other network protocol and deeply > tied to the kernel due to things like descriptor passing or using > the filesystem namespace. I already had to export another symbol that > really should be internal just for it, and if one module acquires lots > of such hacks it's usually a bad sign..
in 2.4 the answer would have been simple; modutils back then used AF_UNIX stuff before it could load modules, so modular was in practice impossible.
Anyway I'd agree with making this non-modular... NOBODY will use this as a module, or if they do loading it somehow is the very first thing done. You just can't live without this, so making it a module is non-sensical.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |