Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] Keys: Deal properly with strnlen_user() | Date | Sat, 18 Feb 2006 16:40:31 +0000 |
| |
Andrew Morton <akpm@osdl.org> wrote:
> ug. Well it's your code ;)
Yeah...
> It should really parameterise `ret' too. > > Are you sure you want to do this? From my reading, doing it with plain old > subroutines would work?
That complicates the error handling and potentially produces less optimal code:-/
I think bringing it together though is definitely the right thing to do: fewer bits to fix and all that.
Davud - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |