Messages in this thread | | | Date | Fri, 17 Feb 2006 13:43:44 +0100 (CET) | From | Roman Zippel <> | Subject | Re: [PATCH v2] Provide an interface for getting the current tick length |
| |
Hi,
On Thu, 16 Feb 2006, john stultz wrote:
> > +u64 current_tick_length(void) > > +{ > > + long delta_nsec; > > + > > + delta_nsec = tick_nsec + adjtime_adjustment() * 1000; > > + return ((u64) delta_nsec << (SHIFT_SCALE - 10)) + time_adj; > > +} > > You've got time_adj here, but you're not using what's been accumulated > in time_phase, is that really ok? > > > Other then that it looks ok to me. I know Roman is working on related > code, so I CC'ed him on this.
I was only thinking about the possibility of increasing the precision already, but that can still be done later. Otherwise this function will only become simpler, so there's no real problem. Actually it should even make NTP4 conversion easier, if ppc uses this value instead of duplicating the calculation.
bye, Roman - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |