Messages in this thread | | | From | Neil Brown <> | Date | Thu, 16 Feb 2006 14:48:20 +1100 | Subject | Re: Possibly bug in radix_tree_delete, and fix. |
| |
On Thursday February 16, nickpiggin@yahoo.com.au wrote: > > It should be basically an identical block to the one below in the main > loop, yeah? You're missing the nr_cleared_tags bit. > > Something like: > > tags[tag] = 1; > if (tag_get(pathp->node, tag, pathp->offset)) { > tag_clear(pathp->node, tag, pathp->offset); > if (!any_tag_set(pathp->node, tag)) { > tags[tag] = 0; > nr_cleared_tags++; > } > } > > And you can add an > Acked-by: Nick Piggin <npiggin@suse.de>
Yes, that's clearly better. I've sent the revised patch out.
Thanks, NeilBrown - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |